-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version cli argument #118
Conversation
Hi @aerialls Thanks for the PR! I think we should keep printing the version on startup too and exit right after if the flag is set. What do you think? |
Hello 👋🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aerialls
Thanks for the PR!
In addition to @lucacome 's comment, could you also update the main README the usage section with the description of the new cli argument - https://github.com/nginxinc/nginx-prometheus-exporter#command-line-arguments ?
Also, we don't usually start commit messages with tags like feat(flag)
. Please take a look at the commit history https://github.com/nginxinc/nginx-prometheus-exporter/commits/master Could you update the commit message? Something like Add version cli argument
or Add version flag
would make sense.
Cheers
d40db8b
to
a1cc26e
Compare
Hello @pleshakov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aerialls
Thanks for addressing the feedback! I have one comment before we merge it. Thanks
Hi @pleshakov, |
@aerialls Thank you! |
Proposed changes
Add a new flag
version
to display the current version. This is useful to check if the exporter needs an update without trying to launch the exporter.Checklist
Before creating a PR, run through this checklist and mark each as complete.