Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WithMaxAPIVersion Option to NginxClient #380

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Add WithMaxAPIVersion Option to NginxClient #380

merged 11 commits into from
Sep 24, 2024

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 17, 2024

Proposed changes

Added WithMaxAPIVersion() which uses the max API version available when creating a new NginxClient.
Added ./idea which are GoLand settings to .gitignore

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@aphralG aphralG requested a review from a team as a code owner September 17, 2024 10:12
@nginx-bot nginx-bot
Copy link

nginx-bot bot commented Sep 17, 2024

Hi @aphralG! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

@nginx-bot nginx-bot bot added the community Issues or PRs opened by an external contributor label Sep 17, 2024
lucacome
lucacome approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

lucacome
lucacome requested changes Sep 18, 2024
View reviewed changes
client/nginx_test.go Outdated Show resolved Hide resolved
@lucacome lucacome mentioned this pull request Sep 24, 2024
Closed
2 tasks
@oliveromahony oliveromahony merged commit 1062d6a into nginxinc:main Sep 24, 2024
14 checks passed
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@dhurley dhurley dhurley approved these changes

@lucacome lucacome lucacome approved these changes

@oliveromahony oliveromahony oliveromahony approved these changes

Assignees
No one assigned
Labels
community Issues or PRs opened by an external contributor enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aphralG @oliveromahony @lucacome @dhurley @kate-osborn