Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yamllint #223

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Add yamllint #223

merged 5 commits into from
Feb 22, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Feb 8, 2024

Proposed changes

Adds yamllint and fixes files

@lucacome lucacome self-assigned this Feb 8, 2024
@lucacome lucacome requested a review from a team as a code owner February 8, 2024 03:40
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 8, 2024
@lucacome lucacome force-pushed the chore/add-yamllint branch 3 times, most recently from d59da8a to 76069da Compare February 8, 2024 03:52
ciarams87
ciarams87 reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the golint is failing here all of a sudden 🤔?

@lucacome
Copy link
Member Author

lucacome commented Feb 8, 2024

I had to fix the other PR too....all of a sudden it started saying that it wasn't gofumpt-ed 🤷‍♂️

@lucacome lucacome requested a review from a team February 15, 2024 23:31
@lucacome lucacome enabled auto-merge (squash) February 16, 2024 20:22
@lucacome lucacome merged commit a151327 into main Feb 22, 2024
12 checks passed
@lucacome lucacome deleted the chore/add-yamllint branch February 22, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @ciarams87 @vepatel