Skip to content

Refactored to "icon" shortcode instead of "fe" #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: mainframe
Choose a base branch
from
+14 −38
Open

Refactored to "icon" shortcode instead of "fe" #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3dfa1a
Icon: Refactored to icon shortcode instead of fe + updated old icon code
lamATnginx Jul 9, 2025
c37dd25
Icon: Fixed lucide partial
lamATnginx Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions exampleSite/content/test-product/feather/_index.md
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions exampleSite/content/test-product/feather/permitted.md
View file
Open in desktop

This file was deleted.

13 changes: 9 additions & 4 deletions exampleSite/content/test-product/lucide/permitted.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,16 @@ weight: 100

[Lucide Icons](https://lucide.dev/) is a free icon library with a permissive license (MIT). We use it for our minimal icon needs in place of FontAwesome in Oldframe.

{{<fe "book-headphones">}}
{{<icon "book-headphones">}}

[Lucide link{{<fe "circle">}}](#)
[Lucide link{{<icon "circle">}}](#)

{{<fe "circle">}} in text.
{{<icon "circle">}} in text.

{{<icon-bug>}}
{{<icon-feature>}}
{{<icon-info>}}
{{<icon-resolved>}}

Here are some icons that are using font-awesome but should be backwards compatible:
<i class="fa-solid fa-check" style="color:green"></i>
Expand Down Expand Up @@ -54,5 +59,5 @@ Here are some icons that are using font-awesome but should be backwards compatib
<i class="fa fa-chevron-down"></i>
<i class="fas fa-flask fa-lg beta-icon"></i>
{{<warning>}}
This is a Warning callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `<warning>` shortcode. It has no custom title. {{<fe "octagon-alert">}}
This is a Warning callout. There was previously a bug with **bold text** that we should be aware of and continue to check for. This callout was invoked with the `<warning>` shortcode. It has no custom title. {{<icon "octagon-alert">}}
{{</warning>}}
5 changes: 1 addition & 4 deletions layouts/partials/lucide.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
{{- /* Usage: */ -}}
{{- /* (dict "context" . "icon" "circle") */ -}}
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" aria-hidden="true" class="lucide"
style="{{ .style | safeCSS }}">
<use href="/images/lucide-sprite.svg#{{ .icon }}"></use>
</svg>
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" aria-hidden="true" class="lucide" style="{{ .style | safeCSS }}"><use href="/images/lucide-sprite.svg#{{ .icon }}"></use></svg>
1 change: 0 additions & 1 deletion layouts/shortcodes/fa.html
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion layouts/shortcodes/icon-bug.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<i class="fa-solid fa-bug" style="color:#E4002B"></i>
{{ partial "lucide" (dict "context" . "icon" "bug" "style" "color:#E4002B") }}
2 changes: 1 addition & 1 deletion layouts/shortcodes/icon-feature.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<i class="fa-solid fa-file-circle-plus" style="color:#009639"></i>
{{ partial "lucide" (dict "context" . "icon" "file-plus" "style" "color:#009639") }}
2 changes: 1 addition & 1 deletion layouts/shortcodes/icon-info.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<i class="fa-solid fa-circle-info" style="color:#1d9cd3;"></i>
{{ partial "lucide" (dict "context" . "icon" "info" "style" "color:#1d9cd3") }}
2 changes: 1 addition & 1 deletion layouts/shortcodes/icon-resolved.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<i class="fa-solid fa-bug-slash" style="color:#666666"></i>
{{ partial "lucide" (dict "context" . "icon" "bug-off" "style" "color:#666666") }}
0 layouts/shortcodes/fe.html → layouts/shortcodes/icon.html
View file
Open in desktop
File renamed without changes.