generated from nginx/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 3
Add new 'card' page to example site + new tests for cards #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview will be available once build job completes!
|
9c1173f
to
07f5ebb
Compare
nginx-jack
reviewed
Jul 8, 2025
nginx-jack
reviewed
Jul 8, 2025
nginx-jack
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Example usage stuff is great 👌 .
10a60d9
to
26b71cd
Compare
26b71cd
to
6db30ba
Compare
9ddc1d1
to
3fde9ea
Compare
lamATnginx
added a commit
that referenced
this pull request
Jul 10, 2025
* Content: Replace with data attribute grid system Add .content class to handle overall content reflow Use scaling fonts Refactor call outs to use grid utilities TODO: Standard mobile sizes horz scroll on some pages TODO: Homepage update to use grid utility TODO: List card layout update to use grid utility * Cards: Replace with data-grid * Cards: Small tweaks * Codeblock: Make highlighted lines stretch to end + fix border * Homepage: Replace with data-grid and cards shortcode * Scroll: Fixed issue with pages overflowing on mobile * Breadcrumb: Cleaned up unused code with wide * Fixed redocly responsive on new grid (#307) * Redoc: Fixed responsive on new grid * Redoc: Fix issue with redocly not going under header * Codeblock: Extend highlight to left side * Cards: Make cards fully clickable + small bug fix with grid ordering * Add new 'card' page to example site + new tests for cards (#305) * Cards: Replace with data-grid * Cards: Add new page to example site * Cards: Add tests * Cards: Small tweaks * Cards: Updated card params in example site * Cards: Fix bugs with the card due to merge * Grid: Resolved issue with grid on mobile * Banner: Add spacing * Card: Fixed relative pathing --------- Co-authored-by: Lam Nguyen <la.nguyen@f5.com> Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add card page to example site + new tests
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)