Skip to content

Mainframe: Deprecate bootstrap-table + Basic 404 Page #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

TasoOneAsia
Copy link
Member

@TasoOneAsia TasoOneAsia commented Jun 30, 2025

Proposed changes

This PR:

  • Deprecates the <bootstrap-table> shortcode and implements the <table> shortcode as the Mainframe table.
    • Under the hood,bootstrap-table calls table with a default variant of "narrow" to maintain backwards compatibility
    • Bootstrap striped table handling not implemented.
    • Documentation needed
  • Implements a simple 404 page with new grid handling.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@TasoOneAsia TasoOneAsia requested a review from a team as a code owner June 30, 2025 19:01
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/293/

@TasoOneAsia
Copy link
Member Author

Narrow + wide table variants can be found on the example site here

Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Runs fine locally but the preview does not use the right 404 page even when cache cleared.

Screenshot 2025-06-30 at 12 51 06 PM

@nginx-jack
Copy link
Collaborator

LGTM. Runs fine locally but the preview does not use the right 404 page even when cache cleared.

Screenshot 2025-06-30 at 12 51 06 PM

That's an oddity with how azure handles 404's unfortunately. Will be fine in dev/staging/prod.

@nginx-jack nginx-jack merged commit bb0c31a into mainframe Jul 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants