Skip to content

Throw error for highlight shortcode #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Throw error for highlight shortcode #225

merged 2 commits into from
Apr 17, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Apr 16, 2025 •
edited
Loading

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/463

Throws the following if highlight shortcode is used explicitly:
Screenshot 2025-04-16 at 12 07 53 PM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Apr 16, 2025
@lamATnginx lamATnginx self-assigned this Apr 16, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 16, 2025 17:55
@lamATnginx lamATnginx changed the title Update highlight shortcode Throw error for highlight shortcode Apr 16, 2025
@lamATnginx lamATnginx added enhancement New feature or request and removed bug Something isn't working labels Apr 16, 2025
danielledeleo
danielledeleo approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@danielledeleo danielledeleo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful thank you.

danielledeleo
danielledeleo requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test file to the example site?

@lamATnginx lamATnginx merged commit 01962b1 into main Apr 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

Assignees

@lamATnginx lamATnginx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @danielledeleo