Feat/callout partial #223
Merged
Feat/callout partial #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-jack
force-pushed
the
feat/callout-partial
branch
from
21be1b2 to
4510f60
Compare
Refactor old blockquote shortcodes to reuse partial Treat Warning Caution Deprecated and Important as special cases which render different HTML to simplify styling Remove ':' from mf titles
nginx-jack
force-pushed
the
feat/callout-partial
branch
from
3440ed5 to
267aa23
Compare
nginx-jack
force-pushed
the
feat/callout-partial
branch
2 times, most recently
from
24af351 to
ad559df
Compare
lamATnginx
approved these changes
Apr 16, 2025
nginx-jack
force-pushed
the
feat/callout-partial
branch
from
ad559df to
dd80672
Compare
danielledeleo
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is pretty much a full rewrite of how callouts work.
All callouts now use the small underlying partial (
callout.html) to render.There are two code paths;
"Caution" "Warning" "Deprecated" "Important"are render one set of html, to make styling and classes easier to managecontentto render the title inside the border. This is configured using a custom attributedata-title, which appears to be the easiest non-js way to configure this outside of css directlyOnly "Loud" callouts support icons right in mf, and they're predetermined by the title itself.
Will have another PR/Ticket to integrate the new icons, we might need a mapping between fa -> feather or do a refactor pass to change the icon usages to all use feather. I vote for the later!
FYI - There should be zero changes visually or in usage in oldframe.