Skip to content

Added styling to ghcode shortcode #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Added styling to ghcode shortcode #220

merged 1 commit into from
Apr 15, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Apr 14, 2025

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/425

Before:
Screenshot 2025-04-14 at 9 33 57 AM

After:
Screenshot 2025-04-14 at 9 33 30 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Apr 14, 2025
@lamATnginx lamATnginx self-assigned this Apr 14, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner April 14, 2025 16:33
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the screenshots, but lgtm other than that 👍

@lamATnginx
Copy link
Collaborator Author

/approve-snapshots

Copy link

Updating snapshots. Click here to see the status.

Copy link

Please download the artifacts here and commit your updated screenshots.

Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@lamATnginx
Copy link
Collaborator Author

/approve-snapshots

Copy link

Updating snapshots. Click here to see the status.

Copy link

Please download the artifacts here and commit your updated screenshots.

@lamATnginx lamATnginx merged commit 941fa38 into main Apr 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants