Skip to content

ExampleSite: Add Everything page #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

ExampleSite: Add Everything page #200

merged 1 commit into from
Mar 31, 2025

Conversation

nginx-jack
Copy link
Collaborator

Remove unused shortcodes (checked documentation and NIC repos)
Add initial spacing

@nginx-jack nginx-jack marked this pull request as ready for review March 28, 2025 14:42
@nginx-jack nginx-jack requested a review from a team as a code owner March 28, 2025 14:42
danielledeleo
danielledeleo approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@danielledeleo danielledeleo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of nginxinc/docs-platform/issues/399

lamATnginx
lamATnginx requested changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adjust spacing on certain items such as

Screenshot 2025-03-28 at 10 56 24 AM
Screenshot 2025-03-28 at 10 56 55 AM

@nginx-jack
Copy link
Collaborator Author

Fixes for blockquote (note/callout etc) and tab groups.
Screenshot 2025-03-31 at 11 36 28

Screenshot 2025-03-31 at 11 36 37

@lamATnginx
Copy link
Collaborator

Thanks for the updated changes. Looks good except for one last item with codeblocks in callouts:

Screenshot 2025-03-31 at 4 58 50 AM

Source: http://localhost:1313/nginx-one/how-to/containers/connect-nginx-plus-container-images-to-nginx-one/#start-the-nginx-plus-container

@nginx-jack
ExampleSite: Add Everything page
326cba3 
Remove unused shortcodes (checked documentation and NIC repos)
Add initial spacing
@nginx-jack
Copy link
Collaborator Author

Changed how gaps are handled in blockquote to be similar to grid-gap used everywhere else.
Screenshot 2025-03-31 at 13 53 08

@nginx-jack nginx-jack merged commit f24df47 into main Mar 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

@lamATnginx lamATnginx lamATnginx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-jack @lamATnginx @danielledeleo