Skip to content

Removed explicit height on sidebar #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Removed explicit height on sidebar #197

merged 1 commit into from
Mar 27, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Removes height of 100vh from sidebar as it is making the page longer than needed as seen in a page such as http://localhost:1313/nginx-gateway-fabric/reference/technical-specifications/

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Mar 26, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 26, 2025 19:08
@nginx-jack nginx-jack merged commit b821047 into main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants