Skip to content

Cleaned up codeblock code + fixed up issue with bottom border #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/409

Before:
Screenshot 2025-03-26 at 10 03 30 AM

After:
Screenshot 2025-03-26 at 10 15 26 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 26, 2025
@lamATnginx lamATnginx self-assigned this Mar 26, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 26, 2025 17:15
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@lamATnginx
Copy link
Collaborator Author

Seems to be an issue with playwright when pulling the artifact. Running again.

Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need to tweak this for the overall spacing/gutter stuff, but this LGTM for now 👍

@lamATnginx lamATnginx merged commit 8686ce6 into main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants