Skip to content

Change cursor on hover for codeblock to text #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/413

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 26, 2025
@lamATnginx lamATnginx self-assigned this Mar 26, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 26, 2025 16:41
@lamATnginx
Copy link
Collaborator Author

Can't grab screenshot. Need to be tested locally.

@nginx-jack
Copy link
Collaborator

This is an odd one; Currently cursor: text; applies to the entire code-block. So anywhere in the box, you'll see a text cursor. In the old them, the text cursor shows up specifically when you're over text, not anywhere in the box, if that makes sense?

@lamATnginx
Copy link
Collaborator Author

I see. Will make appropriate changes. Looks like we do not even need to explicitly state a cursor and this is more an issue with the z-index.

@lamATnginx lamATnginx force-pushed the fix/codeblock-cursor branch from a030e17 to 40a06bc Compare March 26, 2025 18:43
@nginx-jack
Copy link
Collaborator

I see. Will make appropriate changes. Looks like we do not even need to explicitly state a cursor and this is more an issue with the z-index.

Ahh cool. Good find. Thanks :) .

@nginx-jack nginx-jack merged commit 8e9860c into main Mar 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants