Skip to content

Remove border from codeblocks in callouts #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Mar 25, 2025

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/400

Before:
Screenshot 2025-03-25 at 3 03 48 PM

After:
Screenshot 2025-03-25 at 3 03 36 PM

Screenshot 2025-03-25 at 3 12 59 PM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added bug Something isn't working enhancement New feature or request labels Mar 25, 2025
@lamATnginx lamATnginx self-assigned this Mar 25, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 25, 2025 22:03
@lamATnginx lamATnginx removed the bug Something isn't working label Mar 25, 2025
Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - There's some strangeness when the codeblock is part of a list, but we can look at that when we're going through the spacing tickets in general, its not coming from the codeblock itslef.
Screenshot 2025-03-26 at 11 54 27

@lamATnginx lamATnginx merged commit 8ef93fc into main Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants