Skip to content

CodeCopy: Pass codeBlockId via function call #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

nginx-jack
Copy link
Collaborator

Pass codeBlockId via function call instead of pulling from a data attribute. Reduces code complexity a tiny bit.

@nginx-jack nginx-jack requested a review from a team as a code owner March 25, 2025 15:17
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@nginx-jack
Copy link
Collaborator Author

/approve-snapshots

Copy link

Updating snapshots. Click here to see the status.

Copy link

Please download the artifacts here and commit your updated screenshots.

Pass codeBlockId via function call instead of pulling from
a data attribute. Reduces code complexity a tiny bit.
@nginx-jack nginx-jack force-pushed the fix-codeblock-id-attribute branch from 44396c4 to b401909 Compare March 25, 2025 15:27
Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM locally!

@nginx-jack nginx-jack merged commit 3344afc into main Mar 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants