Skip to content

Styles: Override user-agent margin and fix img width #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

TasoOneAsia
Copy link
Member

Proposed changes

This pull request:

  • Increases the specificity of img styling to only target images rendered directly from markdown.
    • Also adds an image to the exampleSite for testing
  • Removes the negative margin property assigned to the footer that could cause x-axis overflow in certain contexts. Also overrides any user-agent default margin that could cause issues as a result of the negative margin change.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@TasoOneAsia TasoOneAsia requested a review from a team as a code owner March 19, 2025 22:51
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@lamATnginx
Copy link
Collaborator

/approve-snapshots

Copy link

Updating snapshots. Click here to see the status.

Copy link

Please download the artifacts here and commit your updated screenshots.

Copy link
Collaborator

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me locally. Thank you!

@TasoOneAsia TasoOneAsia force-pushed the fix-margin+img-width branch from 03e489d to 8355139 Compare March 20, 2025 19:07
Copy link

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@TasoOneAsia
Copy link
Member Author

Updated w/ signed commit

@nginx-jack nginx-jack merged commit 3afdb37 into main Mar 25, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants