feat: update copycode js #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR. |
JTorreG
force-pushed
the
remove-comments-oncopy
branch
from
a144367 to
9fe221f
Compare
For v1 CodeCopy only. v2 will require an different implementation since the code is generated at build time instead of run time.
nginx-jack
force-pushed
the
remove-comments-oncopy
branch
from
67dcaeb to
16ec104
Compare
❌ Playwright visual snapshot differences were detected.View the Playwright report |
nginx-jack
approved these changes
Mar 25, 2025
|
Ran and checked locally. LGTM. I've created a ticket for how this will work with codeblock v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Some code blocks that are being migrated from Unit have comments in the shell/console blocks in # form.
This update aims to improve the copy-code block javascript to detect and remove comments in shell code blocks.
It also updates the function to detect and remove # and $ at the beginning of console/bash commands
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)