Skip to content

Chroma: Added code to bound the width of the codeblock #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Mar 13, 2025

Proposed changes

  • Fixes codeblock so it does not overflow.

Before:
Screenshot 2025-03-13 at 9 04 49 AM

After:
Screenshot 2025-03-13 at 9 03 36 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 13, 2025
@lamATnginx lamATnginx self-assigned this Mar 13, 2025
@lamATnginx lamATnginx requested review from a team as code owners March 13, 2025 16:02
nginx-jack and others added 2 commits March 13, 2025 09:23
This removes the custom render-codeblock as it generated html and class
references that would not work with the standard chroma theme generator.
We may create another render-codeblock in future, if we require a fully
custom theme to render our "fancy codeblocks".
@lamATnginx lamATnginx force-pushed the fix/codeblock-bounds branch from 116bfc1 to 17de998 Compare March 13, 2025 16:23
@lamATnginx lamATnginx merged commit 691d24c into main Mar 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants