Skip to content

Removed note callout redundancy #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

Removed note callout redundancy #163

merged 2 commits into from
Mar 6, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/380

Before:
Screenshot 2025-03-06 at 6 54 48 AM

After:
Screenshot 2025-03-06 at 6 54 35 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 6, 2025
@lamATnginx lamATnginx self-assigned this Mar 6, 2025
@lamATnginx lamATnginx requested review from a team as code owners March 6, 2025 14:55
ADubhlaoich
ADubhlaoich approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though last I checked, these hadn't been implemented at all for the other kinds of call-outs yet.

'warning' is likely the most common.

@lamATnginx lamATnginx merged commit 1c4ad9a into main Mar 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees

@lamATnginx lamATnginx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamATnginx @danielledeleo @ADubhlaoich