Skip to content

Allow qualtric's article effectiveness survey to be full height #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Mar 4, 2025

Proposed changes

Allow qualtrics survey to be full height instead of capped at 350px by default from qualtrics.

Before:
Screenshot 2025-03-04 at 7 06 02 AM

After:
Screenshot 2025-03-04 at 6 47 28 AM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx added the bug Something isn't working label Mar 4, 2025
@lamATnginx lamATnginx self-assigned this Mar 4, 2025
@lamATnginx lamATnginx requested review from a team as code owners March 4, 2025 15:04
@lamATnginx lamATnginx marked this pull request as draft March 4, 2025 15:05
@lamATnginx lamATnginx marked this pull request as ready for review March 4, 2025 15:06
@lamATnginx
Copy link
Collaborator Author

This is a temporary fix to the old theme. The new theme will receive a proper fix to make it full size.

This comment was marked as resolved.

@lamATnginx lamATnginx force-pushed the fix/qualtrics-fs branch 2 times, most recently from eb55a05 to e3dd98a Compare March 5, 2025 20:41
@lamATnginx lamATnginx marked this pull request as draft March 6, 2025 16:58
@lamATnginx lamATnginx marked this pull request as ready for review March 11, 2025 16:10
@lamATnginx lamATnginx merged commit ed12068 into main Mar 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants