Skip to content

NFR Scale test doesn't count all reloads and batches #2009

Open

Description

NFR Scale test doesn't count all reloads and batches.

Example of a run:

## Test TestScale_UpstreamServers

### Reloads

- Total: 61
- Total Errors: 0
- Average Time: 125ms
- Reload distribution:
	- 500ms: 61
	- 1000ms: 61
	- 5000ms: 61
	- 10000ms: 61
	- 30000ms: 61
	- +Infms: 61

### Event Batch Processing

- Total: 64
- Average Time: 232ms
- Event Batch Processing distribution:
	- 500ms: 63
	- 1000ms: 64
	- 5000ms: 64
	- 10000ms: 64
	- 30000ms: 64
	- +Infms: 64

However, looking at the NGF logs, there are 109 reloads and the last batchID is 114:

{"level":"info","ts":"2024-05-22T16:32:46Z","logger":"eventLoop.eventHandler","msg":"Finished handling the batch","batchID":64}
. . .
{"level":"info","ts":"2024-05-22T16:33:01Z","logger":"eventLoop.eventHandler","msg":"NGINX configuration was successfully updated","batchID":114}

Full log https://github.com/nginxinc/nginx-gateway-fabric/blob/d443d6a55988eae8091d230dbbd90ceef1de2c8f/tests/results/scale/edge/TestScale_UpstreamServers/ngf.log

Acceptance criteria:

  • Make sure reloads and batches are counted correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    refinedRequirements are refined and the issue is ready to be implemented.size/mediumEstimated to be completed within a weektestsPull requests that update tests

    Type

    No type

    Projects

    • Status

      🆕 New

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions