Updates to move to R34 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the NGINX Plus workshop environment to move from R32 to R34, implementing modernized Docker build strategies and addressing infrastructure dependencies.
Key changes include:
- Multi-stage Docker builds with F5 private registry base images
- Updated
wrkload testing tool from deprecatedwilliamyeh/wrktoelswork/wrk - Removal of Lab7 (NGINX One Console) functionality and complete file deletion
Reviewed Changes
Copilot reviewed 44 out of 107 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Plus/labs/lab1/ | Updated Dockerfile to use multi-stage builds and R34 base images; modified documentation for new licensing workflow |
| Plus/labs/lab2-6/ | Updated docker-compose files to standardize volume mounting and add JWT token copying; updated wrk image references |
| Plus/labs/lab7/ | Complete removal of all lab7 files including documentation, configurations, and Docker compose setup |
| ------------- | ||
| Navigate to ([Lab7](../lab7/readme.md) | [Main Menu](../readme.md)) | ||
| Navigate to ([Main Menu](../readme.md)) |
There was a problem hiding this comment.
The navigation link should be updated to reflect the removal of Lab7. Consider adding a note about Lab7 being removed or updating the lab sequence documentation.
Suggested change
| Navigate to ([Main Menu](../readme.md)) | |
| Navigate to ([Main Menu](../readme.md)) | Note: Lab7 has been removed. The lab sequence now ends with Lab6. |
Copilot uses AI. Check for mistakes.
apcurrier
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the key things that got updated:
nginx-repo.jwtshould be copied to labs folder as all the docker-compose files within each lab need to add it to the container.wrkimage fromwilliamyeh/wrktoelswork/wrk