-
Notifications
You must be signed in to change notification settings - Fork 12
Lab guide edits as per last workshop feedback #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sdutta9
commented
May 30, 2025
- Updated lab0 to include guac server details.
- Updated lab1 based on feedback from workshop
- Update lab2 to add sudo to all vi commands to update /etc/hosts.
- Update lab7 to run generate_certs.sh script that creates the self-signed certs for NGINX oss. Also removed other deep dive sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates several lab guides based on workshop feedback. Key changes include:
- Lab7: Updates instructions to generate self-signed certificates via a new script and removes outdated deep dive sections.
- Lab2 & Lab0: Adds sudo to commands modifying /etc/hosts and refines RDP instructions.
- Lab1: Refines instructions for creating configuration files in the proper directory.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Plus/labs/lab7/readme.md | Updates to certificate generation instructions and removal of deep dive content; minor spelling correction needed. |
Plus/labs/lab7/generate_certs.sh | New script to generate certificates; uses $NAME without documenting its source. |
Plus/labs/lab2/readme.md | Minor changes to command usage by adding sudo. |
Plus/labs/lab1/readme.md | Updated file creation instructions for improved clarity. |
Plus/labs/lab0/readme.md | Updated RDP instructions and renamed 'Jumpbox' to 'Jumphost'. |
Comments suppressed due to low confidence (1)
Plus/labs/lab7/readme.md:137
- The word 'Suceeded' appears to be misspelled; consider changing it to 'Succeeded'.
You should see a `Login Suceeded` message, like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the lab guides to reflect the latest workshop feedback by modifying instructions, file paths, and command examples across multiple lab files. Key changes include:
- Updating usage instructions and adding required commands (e.g., sudo for editing /etc/hosts, running generate_certs.sh).
- Refining file paths and visual guidance in lab7 and lab1.
- Revising lab0 content to clearly differentiate connection options for the Jumphost.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Plus/labs/lab7/readme.md | Updated JWT file path, added self-signed cert generation step, and cleaned up extraneous deep dive sections. |
Plus/labs/lab7/generate_certs.sh | Added a simple script to generate 1-day and 30-day self-signed certificates. |
Plus/labs/lab2/readme.md | Modified commands to use sudo when editing /etc/hosts. |
Plus/labs/lab1/readme.md | Revised instructions for creating configuration files with updated screenshots. |
Plus/labs/lab0/readme.md | Updated RDP instructions and renamed "Jumpbox" to "Jumphost" with enhanced visual guidance. |
Comments suppressed due to low confidence (1)
Plus/labs/lab7/readme.md:137
- Typo in 'Login Suceeded'; consider correcting it to 'Login Succeeded' for clarity.
You should see a `Login Suceeded` message, like this: