Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus latency collector #1130

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Add prometheus latency collector #1130

merged 1 commit into from
Sep 8, 2020

Conversation

kate-osborn
Copy link
Contributor

Proposed changes

Adds prometheus latency collector that calculates http upstream server latency in milliseconds using a prometheus histogram vector.
Latency metrics are published under the names:

  • nginx_ingress_controller_upstream_server_response_latency_ms_bucket
  • nginx_ingress_controller_upstream_server_response_latency_ms_sum
  • nginx_ingress_controller_upstream_server_response_latency_ms_count

The metrics have the following labels: upstream, server, resource_namespace, resource_type, resource_name, service, pod_name, and code.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kate-osborn kate-osborn merged commit 9097f49 into master Sep 8, 2020
@kate-osborn kate-osborn deleted the latency-metrics branch September 8, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants