Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for App Protect module #1035

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Support for App Protect module #1035

merged 1 commit into from
Jul 3, 2020

Conversation

rafwegv
Copy link
Contributor

@rafwegv rafwegv commented Jul 3, 2020 •
edited by Rulox
Loading

Proposed changes

This PR introduces support to use the Kubernetes Ingress Controller for NGINX Plus with the NGINX App Protect module. https://www.nginx.com/products/nginx-app-protect/

  • New Dockerfile for Plus and App Protect module
  • 2 New CRDS (Policy and LogConf) to fine grain AP configuration per Ingress Resource
  • New Ingress annotations to enable/configure AP module
  • New configmap keys for global AP onfiguration

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox requested review from Rulox and Dean-Coakley July 3, 2020 10:46
@Rulox Rulox mentioned this pull request Jul 3, 2020
Closed
6 tasks
@Rulox Rulox requested a review from LorcanMcVeigh July 3, 2020 10:49
@rafwegv rafwegv merged commit 6c9347b into master Jul 3, 2020
@pleshakov pleshakov added the enhancement Pull requests for new features/feature enhancements label Jul 8, 2020
@pleshakov pleshakov deleted the app-protect-support branch July 8, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rulox Rulox Rulox approved these changes

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@Dean-Coakley Dean-Coakley Awaiting requested review from Dean-Coakley

Assignees
No one assigned
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafwegv @Rulox @LorcanMcVeigh @pleshakov