Add IPv6 support for local-resolvers substitution script #855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When running in IPv6 networks, the
15-local-resolvers.envsh
script will create invalid nginx configuration because the IPv6 address is not wrapped in brackets as Nginx requires. This change checks for the presence of colons (which all valid IPv6 addresses should have), and wraps the address in square brackets./etc/resolv.conf
syntax should never present a host and port together, so it is a valid assumption that an IPv4 nameserver configuration will never have a colon present.This is incredibly useful for getting DNS working in IPv6 Kubernetes environments.
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTING
document./update.sh
and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles