Minor script beautifying #819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessfg
force-pushed
the
bug-fix-and-linter
branch
from
71f6a24
to
fb409b4
Compare
alessfg
force-pushed
the
bug-fix-and-linter
branch
5 times, most recently
from
d618fd4
to
0052b8b
Compare
|
Hello! Can you split actual fixes (like -n vs -f) and unrelated changes into separate commits? Also, I'm not sure whitespace (and beautyfing, like splitting oneliners into multilines) changes are worth the effort, since by default vim will not honor modelines anyway - and they would pollute the history and blame. |
|
See #824 😄 |
alessfg
force-pushed
the
bug-fix-and-linter
branch
2 times, most recently
from
bdc3c7e
to
5f213fc
Compare
alessfg
force-pushed
the
bug-fix-and-linter
branch
from
5f213fc
to
6982fdc
Compare
alessfg
changed the title
|
I do think there is something to be gained in readability for folks that are looking through the scripts either here or using a code editor instead of VIM, but I get your point. I will tweak the PR to get rid of some of the superfluous "beautifying" (e.g. revert the oneliner to multiline changes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* Fix small bug with using the-nflag instead of the-fflag when checking if files are available (https://github.com/nginxinc/docker-nginx/blob/master/Dockerfile-alpine-slim.template#L76-L78)* Fix some shell linter warnings* Minor script formatting/beautifyingRebased this PR to only include some minor script formatting