Bugfix for Lua comments with apostrophe #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aluttik
reviewed
Jul 13, 2020
aluttik
reviewed
Jul 13, 2020
Add Python 2 support Co-authored-by: Arie van Luttikhuizen <aluttik@gmail.com>
Add extra bracket for testing
|
Hey, |
|
It looks good to me, but you'll need an NGINX employee to take a look and merge. I'll ping one 🙂 |
|
We are struggling because of this also! |
|
@framer777 @Raymond26 could you guys take a look? TIA! |
Hey @framer777 and @Raymond26 , anything new? |
|
sorry for the delay, I was OOO. Going to merge and create a release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Bugfix for the following issue - #87
Checklist
Before creating a PR, run through this checklist and mark each as complete.