Skip to content

Limit_req_zone can support 4 arguments (sync) #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

Limit_req_zone can support 4 arguments (sync) #77

merged 1 commit into from
Apr 10, 2020

Conversation

mbibaud
Copy link
Contributor

@mbibaud mbibaud commented Mar 17, 2020

Proposed changes

limit_req_zone can support up to 4 arguments since the introduction of sync:
http://nginx.org/en/docs/http/ngx_http_limit_req_module.html#limit_req_zone

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@mbibaud mbibaud mentioned this pull request Mar 17, 2020
Closed
defanator
defanator approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@defanator defanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Raymond26 Raymond26 self-requested a review April 1, 2020 19:42
@framer777 framer777 merged commit 9fcfff6 into nginxinc:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raymond26 Raymond26 Raymond26 approved these changes

@defanator defanator defanator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbibaud @Raymond26 @defanator @framer777