Skip to content

Added support for comments between arguments #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

Added support for comments between arguments #68

merged 1 commit into from
Apr 8, 2019

Conversation

aluttik
Copy link
Contributor

@aluttik aluttik commented Apr 5, 2019

Take this for example:

http { #comment 1
    log_format #comment 2
        \#arg\ 1 #comment 3
        '#arg 2' #comment 4
        #comment 5
        ;
}

Before this change, comments 2-5 would be read as arguments. Now they'll all be parsed as comments with the same line number as the log_format directive.

framer777
framer777 approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@framer777 framer777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨

@Raymond26
Copy link

💨

@aluttik aluttik merged commit c035082 into master Apr 8, 2019
@aluttik aluttik deleted the comments-between-args-support branch April 8, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electricjesus electricjesus electricjesus approved these changes

@framer777 framer777 framer777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aluttik @Raymond26 @electricjesus @framer777