Skip to content

Fix port number in listener object for php hello world app #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix port number in listener object for php hello world app #995

wants to merge 1 commit into from

Conversation

oCHRISo
Copy link
Contributor

@oCHRISo oCHRISo commented Nov 8, 2023

Changing port number from 8000 to 8080 for the php hello world app

@lcrilly lcrilly requested a review from a user November 8, 2023 11:57
@lcrilly lcrilly added the z-documentation-update-needed This type of issues likely have a link to an issue in the Unit Docs repo label Nov 8, 2023
ac000
ac000 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ac000
Copy link
Member

ac000 commented Nov 10, 2023

Hmm, 6f63cc8

@ac000
Copy link
Member

ac000 commented Nov 21, 2023

Merged as 3fdf8c6, thanks!

@ac000 ac000 closed this Nov 21, 2023
@oCHRISo oCHRISo deleted the fix-port-number-for-hello-world branch November 21, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ac000 ac000 ac000 approved these changes

Assignees
No one assigned
Labels
z-documentation-update-needed This type of issues likely have a link to an issue in the Unit Docs repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oCHRISo @ac000 @lcrilly