Skip to content

docs: update njs build instructions #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2024
Merged

docs: update njs build instructions #154

merged 5 commits into from
Jun 17, 2024

Conversation

JTorreG
Copy link
Collaborator

@JTorreG JTorreG commented Jun 13, 2024

Update the Enabling njs steps to include changing branches to the latest supported version

image

@JTorreG JTorreG self-assigned this Jun 13, 2024
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for nginx-unit ready!

Name Link
🔨 Latest commit a32c52f
🔍 Latest deploy log https://app.netlify.com/sites/nginx-unit/deploys/66704eac5dac560008ba9f63
😎 Deploy Preview https://deploy-preview-154--nginx-unit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ac000
Copy link
Member

ac000 commented Jun 13, 2024

njs has moved to GitHub

Copy link
Collaborator

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Two small suggestions at your option.

@callahad
Copy link
Collaborator

Seconding @ac000's suggestion of removing mentions of mercurial given the mailing list announcement he pointed to.

@JTorreG
Copy link
Collaborator Author

JTorreG commented Jun 13, 2024

removed the mercurial steps
changed the git steps to

 $ git clone https://github.com/nginx/njs.git
 $ cd njs
 $ git checkout -b 0.8.2 0.8.2

@JTorreG JTorreG requested review from ac000 and callahad June 13, 2024 14:23
@JTorreG JTorreG merged commit 4f116f7 into main Jun 17, 2024
4 checks passed
@JTorreG JTorreG deleted the njs-version branch June 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants