Skip to content

Conversation

@xeioex
Copy link
Contributor

@xeioex xeioex commented Sep 11, 2025

No description provided.

@xeioex xeioex force-pushed the fetch_keepalive branch 2 times, most recently from 7a19acc to 239eda9 Compare September 11, 2025 05:45
VadimZhestikov
VadimZhestikov previously approved these changes Sep 11, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

VadimZhestikov
VadimZhestikov previously approved these changes Sep 12, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition

hongzhidao
hongzhidao previously approved these changes Sep 12, 2025
Copy link
Contributor

@hongzhidao hongzhidao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

hongzhidao
hongzhidao previously approved these changes Sep 12, 2025
VadimZhestikov
VadimZhestikov previously approved these changes Sep 12, 2025
@xeioex
Copy link
Contributor Author

xeioex commented Sep 14, 2025

TODO: remove ip address match when looking for a connection to reuse. Use (scheme, host, port) tuple instead.

Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This closes nginx#957 feature request on Github.
@xeioex xeioex merged commit 7b3c8a6 into nginx:master Sep 16, 2025
2 checks passed
@xeioex xeioex deleted the fetch_keepalive branch September 16, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants