Skip to content

Conversation

@xeioex
Copy link
Contributor

@xeioex xeioex commented Aug 15, 2025

No description provided.

@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 8eec0d2 to 99f0aff Compare August 19, 2025 04:47
@xeioex xeioex marked this pull request as ready for review August 19, 2025 04:53
@xeioex xeioex requested a review from VadimZhestikov August 19, 2025 05:12
VadimZhestikov
VadimZhestikov previously approved these changes Aug 19, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 99f0aff to 10a87b6 Compare August 20, 2025 00:32
@xeioex xeioex requested a review from VadimZhestikov August 20, 2025 00:33
@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 10a87b6 to 17a27e1 Compare August 20, 2025 01:18
VadimZhestikov
VadimZhestikov previously approved these changes Aug 20, 2025
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 17a27e1 to 2dbd4af Compare August 26, 2025 02:36
@xeioex xeioex requested a review from VadimZhestikov August 26, 2025 02:36
Copy link
Contributor

@VadimZhestikov VadimZhestikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 2dbd4af to 64ac2ff Compare August 27, 2025 00:42
xeioex added 3 commits August 26, 2025 18:05
This allows to stream long tcp streams or large http response bodies
with low memory consumption.

This works only for qjs engine, because njs has no GC.

This fixes nginx#943 issue on Github.
@xeioex xeioex force-pushed the fix_long_running_streams_in_tcp_stream branch from 64ac2ff to 14cb3b3 Compare August 27, 2025 01:09
@xeioex xeioex merged commit 44744d9 into nginx:master Aug 27, 2025
2 checks passed
@xeioex xeioex deleted the fix_long_running_streams_in_tcp_stream branch August 27, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants