Removed NGX_MAX_PATH define. #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
requested changes
Jun 9, 2025
Contributor
xeioex
left a comment
xeioex
left a comment
There was a problem hiding this comment.
We are using past tense and a dot at the end for commit logs.
Remove NGX_MAX_PATH define -> Removed NGX_MAX_PATH define.
Otherwise look good.
Already defined in ngx_files.h (included from ngx_core.h).
Contributor
Author
|
Done |
xeioex
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Already defined in ngx_files.h (included from ngx_core.h).
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument