Skip to content

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Jun 3, 2025

  • Inconsistent inline.
  • Integer constant is too large for 'long' type (with mips -mabi=n32).

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes

@xeioex
Copy link
Contributor

xeioex commented Jun 4, 2025

Hi @orgads,

thank you for the PR. I am trying to reproduce the issue, but I failed so far.

readelf -h ./build/njs | grep -E "(Class|Machine|Flags)"
  Class:                             ELF32
  Machine:                           MIPS R3000
  Flags:                             0x80000027, noreorder, pic, cpic, abi2, mips64r2

could you, please, elaborate more about the system you are compiling on?

@orgads
Copy link
Contributor Author

orgads commented Jun 4, 2025

Hi,

Reproduces for me with the following command:

mips64-octeon-linux-gnu-gcc -c -Isrc -Iexternal -Ibuild -pipe -fPIC -fvisibility=hidden -O -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g -O -mabi=n32 -o build/external/njs_md5.o external/njs_md5.c

This is gcc 4.1, I know it's old, but in this case the warnings seem to be correct.

@xeioex
Copy link
Contributor

xeioex commented Jun 5, 2025

Hi @orgads,

Could you, please, check that #926 fixes your issues?

* Inconsistent inline.
* Integer constant is too large for 'long' type (with mips -mabi=n32).
@orgads
Copy link
Contributor Author

orgads commented Jun 6, 2025

@xeioex Adapted to your preferred change (replaced static with inline). The change is now minimal.

@xeioex
Copy link
Contributor

xeioex commented Jun 8, 2025

@orgads

Thanks. Committed in #926.

@xeioex xeioex closed this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants