Fixed regexp undefined value of captured group. #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
previously requested changes
May 1, 2025
Contributor
xeioex
left a comment
xeioex
left a comment
There was a problem hiding this comment.
For commit log, please, also add
Found by OSS-Fuzz.
VadimZhestikov
force-pushed
the
regexp_captured_group
branch
from
bfce55b to
95e784e
Compare
xeioex
force-pushed
the
regexp_captured_group
branch
from
95e784e to
91a8dd1
Compare
Found by OSS-Fuzz.
VadimZhestikov
force-pushed
the
regexp_captured_group
branch
from
91a8dd1 to
018c6d0
Compare
Contributor
Author
|
test262 is ok |
xeioex
approved these changes
May 1, 2025
xeioex
added a commit
to xeioex/njs
that referenced
this pull request
Nov 25, 2025
See https://www.gnu.org/prep/standards/html_node/Command-Variables.html and discussion in nginx#900 issue on Github.
xeioex
added a commit
to xeioex/njs
that referenced
this pull request
Dec 2, 2025
See https://www.gnu.org/prep/standards/html_node/Command-Variables.html and discussion in nginx#900 issue on Github.
xeioex
added a commit
to xeioex/njs
that referenced
this pull request
Dec 13, 2025
See https://www.gnu.org/prep/standards/html_node/Command-Variables.html and discussion in nginx#900 issue on Github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was found by OSS-Fuzz. Segmentation fault at the input:
' a'.split(/|()/)
Actually that is old issue: previously (before removing short_strings in #848) to obtain value of captured group was used njs_string_prop() without check for its value argument type and it by mistake converted undefined value to empty string, while there is expected undefined value itself. After removing short_strings, njs_string prop() throws segmentation fault.