doc: use shared_dict for dynamic certs demo #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as NJS v0.8.0 is not available in nginx docker images as of today, you can use: # syntax=docker/dockerfile:1
ARG NGINX_VERSION=1.25.1
ARG NJS_VERSION=0.8.0
FROM nginx:${NGINX_VERSION}
ARG NGINX_VERSION
ARG NJS_VERSION
RUN --mount=type=cache,target=/var/cache/apt <<EOF
set -eux
export DEBIAN_FRONTEND=noninteractive
apt-get -qq update
apt-get -qq install --yes --no-install-recommends --no-install-suggests \
curl gnupg2 ca-certificates debian-archive-keyring inotify-tools
update-ca-certificates
apt-get remove --purge --auto-remove --yes
EOF
# As of 07/13/2023 NJS v0.8.0 is not included into nginx docker image.
# This a temprary to install it
# Following installation steps from http://nginx.org/en/linux_packages.html#Debian
RUN --mount=type=cache,target=/var/cache/apt <<EOF
set -eux
export DEBIAN_FRONTEND=noninteractive
apt-get -qq update
curl https://nginx.org/keys/nginx_signing.key | gpg --dearmor \
| tee /usr/share/keyrings/nginx-archive-keyring.gpg >/dev/null
gpg --dry-run --quiet --no-keyring --import --import-options import-show \
/usr/share/keyrings/nginx-archive-keyring.gpg
echo "deb [signed-by=/usr/share/keyrings/nginx-archive-keyring.gpg] \
http://nginx.org/packages/mainline/debian $(echo $PKG_RELEASE | cut -f2 -d~) nginx" \
| tee /etc/apt/sources.list.d/nginx.list
apt-get -qq update
apt-get -qq install --yes --no-install-recommends --no-install-suggests \
nginx-module-njs=${NGINX_VERSION}+${NJS_VERSION}-${PKG_RELEASE}
apt-get remove --purge --auto-remove --yes
rm -rf /var/lib/apt/lists/* /etc/apt/sources.list.d/nginx.list
EOF
|
ivanitskiy
force-pushed
the
master
branch
4 times, most recently
from
a51762c to
473ac84
Compare
xeioex
requested changes
Jul 27, 2023
README.rst
Outdated
| * - Validate and sanitize uploaded file content to prevent security risks. | ||
| */ | ||
|
|
||
| import fs from 'fs' |
There was a problem hiding this comment.
Because this is an example, I suggest to remove non-essential code from the .rst page, leave only the crucial parts.
There was a problem hiding this comment.
please take a look again.
xeioex
requested changes
Aug 8, 2023
README.rst
Outdated
|
|
||
| Note: this example below work with njs >= `0.8.0 <http://nginx.org/en/docs/njs/changes.html#njs0.8.0>`_. | ||
|
|
||
| This example demonstrtaes: |
There was a problem hiding this comment.
demonstrtaes -> demonstrates
| } | ||
|
|
||
|
|
||
| Here we would implement ``js_set`` handlers that reads cert/key from a FS or from `shared_dict`` (used as a cache here): |
There was a problem hiding this comment.
would implement -> implement ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demo shows how to use the new shared_dict_zone with NJS v.0.8.0 and up to set up NGINX to serve encrypted traffic without server restarts when the certificate or key changes occur