Implements #23 - Ensure if servername config changes that certs are updated #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Recognize if
njs_acme_server_names
no longer matches the stored certificate. If so, request a new cert with the configured names.Also includes a handful of small changes for DRYing up (e.g. adds
acmeCommonName(r)
andacmeAltNames(r)
methods), defines some more specific types, renames some variables/methods to be more accurate. Adds a second server name to the example config to demonstrate this clearly.These changes ended up making the PR bigger than I expected. Happy to remove the changes to make this one lean.
TODO: Add unit tests when #24 is merged (contains unit test framework improvements).
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentREADME.md
andCHANGELOG.md
)