Use prebuilt nginx tree if $NGX_OBJS is specified #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tested it on Ubuntu 22.04 arm64. |
bavshin-f5
force-pushed
the
add-dynamic-module
branch
from
2dbbb9c to
3177015
Compare
bavshin-f5
force-pushed
the
add-dynamic-module
branch
2 times, most recently
from
c0ba98c to
4e6520f
Compare
Member
Author
|
Almost done, |
Contributor
|
Awesome work @bavshin-f5 ! Great to see this coming up finally! Thanks |
This should help integrating the modules into the NGINX build process with `--add-dynamic-module`.
bavshin-f5
force-pushed
the
add-dynamic-module
branch
from
f7dc512 to
f2f9bf3
Compare
dekobon
approved these changes
Apr 23, 2024
Contributor
dekobon
left a comment
dekobon
left a comment
There was a problem hiding this comment.
@bavshin-f5 Thank you for the contribution. I only have small language and comment related suggestions. Please incorporate the feedback or disregard it based on your judgement. Otherwise, this looks good and I think we can merge it if it passes CI.
These dependencies are not necessary when using an existing NGINX source tree.
Breaking, as it changes the type of all the string constants in the bindings.
bavshin-f5
force-pushed
the
add-dynamic-module
branch
from
f2f9bf3 to
91a042b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards addressing #42.
NGX_OBJS=/path/to/nginx/objs cargo buildwill skip downloading sources and use headers from existing configured copy of the Nginx source tree.I'll update README and provide
config/config.makeexamples later.