Skip to content

Build for more platforms #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Build for more platforms #844

merged 6 commits into from
Sep 30, 2024

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Sep 16, 2024

Proposed changes

Debian builds packages for ppc64 and riscv64. Alpine supports mips64.
NGINX runs on freebsd and solaris.
This PR adds support for all those architectures and platforms.
It also adds docker builds for all variants of arm and riscv64

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 16, 2024
@lucacome lucacome force-pushed the chore/more-platforms branch 2 times, most recently from e69445e to a1564ea Compare September 16, 2024 02:41
@lucacome lucacome force-pushed the chore/more-platforms branch from a1564ea to 3672673 Compare September 16, 2024 02:54
@lucacome lucacome marked this pull request as ready for review September 16, 2024 03:05
@lucacome lucacome requested a review from a team as a code owner September 16, 2024 03:05
@lucacome lucacome self-assigned this Sep 18, 2024
Copy link
Collaborator

@pdabelf5 pdabelf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're building for solaris, is that just x86 or sparc too?

@lucacome
Copy link
Contributor Author

Solaris is only amd64, this is the list of supported OSes and architectures https://go.dev/doc/install/source#environment

Signed-off-by: Luca Comellini <luca.com@gmail.com>
@lucacome lucacome requested a review from a team September 23, 2024 17:30
@lucacome lucacome requested a review from a team September 26, 2024 18:06
@lucacome lucacome enabled auto-merge (squash) September 30, 2024 15:36
@lucacome lucacome merged commit 9cd3941 into main Sep 30, 2024
15 checks passed
@lucacome lucacome deleted the chore/more-platforms branch September 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants