Skip to content

Add linters that check for bugs #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Add linters that check for bugs #779

merged 4 commits into from
Jul 18, 2024

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Jul 17, 2024

Proposed changes

Adds linters that check for bugs and fixes errors.
See first commit for the errors.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome requested a review from a team as a code owner July 17, 2024 01:12
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 3.86%. Comparing base (4fca542) to head (1e062c0).

Files Patch % Lines
collector/nginx_plus.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #779      +/-   ##
========================================
- Coverage   3.86%   3.86%   -0.01%     
========================================
  Files          5       5              
  Lines       1319    1321       +2     
========================================
  Hits          51      51              
- Misses      1268    1270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome added this to the v1.3.0 milestone Jul 17, 2024
@lucacome lucacome requested a review from a team July 17, 2024 17:07
@lucacome lucacome enabled auto-merge (squash) July 18, 2024 06:40
@lucacome lucacome merged commit dccd7cc into main Jul 18, 2024
14 checks passed
@lucacome lucacome deleted the chore/add-linter-bugs branch July 18, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants