Skip to content

Restore the old behavior when 'nginx-prometheus-exporter' was the default rule for make #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Restore the old behavior when 'nginx-prometheus-exporter' was the default rule for make #621

merged 1 commit into from
Feb 13, 2024

Conversation

dominikwinter
Copy link
Contributor

Proposed changes

This pull request resolves #620.

In the Makefile, the help and nginx-prometheus-exporter targets have been swapped, now making nginx-prometheus-exporter the default target again. This adjusts the default build command ensuring consistency with the instructions in README.md.

Please provide feedback if further changes are needed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@dominikwinter dominikwinter requested a review from a team as a code owner February 3, 2024 03:12
@lucacome
Copy link
Contributor

lucacome commented Feb 3, 2024

Hi @dominikwinter

thanks for the PR! I think it would be better to update the README to use make nginx-prometheus-exporter and leave an empty command to show the help...any particular reason why you want make to build the binary?

@dominikwinter
Copy link
Contributor Author

Hi @lucacome,

The ticket was relatively clear to me as it is a notable convention in the open source community. Many user are accustomed to the defaults like make and make install.

On the other hand, I understand clear targets like make nginx-prometheus-exporter can help newcomers.

But what's best - keep to the norm or make it as clear as possible? :)

Let me know what you think.

Copy link
Contributor

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, left a comment.

@lucacome lucacome requested a review from a team February 5, 2024 22:51
@lucacome lucacome merged commit 37c762b into nginx:main Feb 13, 2024
@lucacome lucacome added the chore Pull requests for routine tasks label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build instructions incorrect since 1.0.0
4 participants