- 
                Notifications
    You must be signed in to change notification settings 
- Fork 141
Warnings for unsupported Gateway and Routes fields #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          
      
        
          +697
        
        
          −4
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
- Coverage   86.74%   86.73%   -0.01%     
==========================================
  Files         128      128              
  Lines       16664    16758      +94     
  Branches       62       62              
==========================================
+ Hits        14455    14535      +80     
- Misses       2026     2039      +13     
- Partials      183      184       +1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
              
                    ciarams87
  
              
              reviewed
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    ciarams87
  
              
              requested changes
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
              
                    salonichf5
  
              
              requested changes
              
                  
                    Oct 7, 2025 
                  
              
              
            
            
798c498    to
    ac3e22e      
    Compare
  
    
              
                    ciarams87
  
              
              requested changes
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
16728da    to
    e9719f7      
    Compare
  
    
              
                    ciarams87
  
              
              requested changes
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
              
                    salonichf5
  
              
              reviewed
              
                  
                    Oct 8, 2025 
                  
              
              
            
            
e9719f7    to
    43e0c77      
    Compare
  
    
              
                    ciarams87
  
              
              reviewed
              
                  
                    Oct 9, 2025 
                  
              
              
            
            
43e0c77    to
    89b9190      
    Compare
  
    
              
                    ciarams87
  
              
              approved these changes
              
                  
                    Oct 9, 2025 
                  
              
              
            
            
              
                    salonichf5
  
              
              approved these changes
              
                  
                    Oct 9, 2025 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Proposed changes
Problem:
As an NGF user,
I want clear feedback when I've specified a field that is unsupported by NGF,
So that I understand why certain features aren't working.
Routes should still be considered valid and configured, so we don't break existing users
Solution:
For all fields in various resources (Gateway, HTTPRoute, GRPCRoute, etc) that NGF does not yet support, add validation and error conditions if they are specified
Routes should still be considered valid and configured, so we don't break existing users
Testing: Unit tests


deploy:
Please focus on (optional):
for documentation:
nginx/documentation#1268
Closes #3784
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.