Skip to content

Update directory structure #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Update directory structure #3401

merged 1 commit into from
May 27, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented May 23, 2025

Problem: Now that the original provisioner mode has been removed, we don't need the nested mode/static directory structure. The naming no longer makes sense.

Solution: Updated mode/static directory to controller, and moved some of the framework packages into controller. Other packages in framework were left alone since many of them are general enough for "controller building" use.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added documentation Improvements or additions to documentation chore Pull requests for routine tasks tests Pull requests that update tests labels May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 57.21271% with 175 lines in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (b7c7c2d) to head (fd8ccaf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/controller/state/conditions/conditions.go 17.78% 171 Missing ⚠️
internal/controller/manager.go 0.00% 3 Missing ⚠️
cmd/gateway/commands.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3401      +/-   ##
==========================================
- Coverage   86.80%   86.78%   -0.03%     
==========================================
  Files         129      127       -2     
  Lines       15011    15011              
  Branches       62       62              
==========================================
- Hits        13031    13027       -4     
- Misses       1830     1833       +3     
- Partials      150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman marked this pull request as ready for review May 23, 2025 17:54
@sjberman sjberman requested a review from a team as a code owner May 23, 2025 17:54
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Problem: Now that the original provisioner mode has been removed, we don't need the nested `mode/static` directory structure. The naming no longer makes sense.

Solution: Updated `mode/static` directory to `controller`, and moved some of the `framework` packages into `controller`. Other packages in `framework` were left alone since many of them are general enough for "controller building" use.
@sjberman sjberman force-pushed the chore/directory-structure branch from acd748a to fd8ccaf Compare May 27, 2025 22:04
@sjberman sjberman enabled auto-merge (squash) May 27, 2025 22:06
@sjberman sjberman merged commit 209f028 into main May 27, 2025
41 of 42 checks passed
@sjberman sjberman deleted the chore/directory-structure branch May 27, 2025 22:26
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants