-
Notifications
You must be signed in to change notification settings - Fork 122
Support provisioning of Gateway(s) in helm chart #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3399 +/- ##
==========================================
+ Coverage 86.74% 86.77% +0.02%
==========================================
Files 129 129
Lines 14928 14928
Branches 62 62
==========================================
+ Hits 12950 12954 +4
+ Misses 1827 1823 -4
Partials 151 151 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With this example values.yaml file:
I get the following Gateway resources when printed out through
Also confirmed no gateways included in values.yaml, correctly does not produce a gateway object when deploying through helm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work !
bffaeed
to
6ce4773
Compare
Proposed changes
Support provisioning of Gateway(s) in helm chart.
Problem: Users would like to provision a Gateway through the helm chart.
Solution: Support provisioning of Gateway(s) in helm chart.
Testing: Manually tested templating and installation of an example values.yaml file.
Closes #1533
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.