Skip to content

Add enhancement proposal for NAP WAF integration #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented May 22, 2025

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: As a maintainer of NGF
I want a design to describe what the UX and high level implementation details I need for WAF v5
So that I can implement that design later to build the feature in NGF.

Solution: Create an enhancement proposal detailing the architecture of the proposed design. Note this does not go into any code specific implementation details or design, this proposal is focused on the overall architecture and approach.

Testing: Deployed the multi-container NGINX pod with NAP WAF installed as detailed in the proposal, and ensured WAF protection was running against the traffic. I have not tested any of the Policy pulling mechanisms detailed in the proposal.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3341

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested review from a team as code owners May 22, 2025 17:35
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 22, 2025
@ciarams87 ciarams87 added the enhancement-proposal Enhancement Proposal issue label May 22, 2025
@ciarams87 ciarams87 force-pushed the docs/nap-waf-proposal branch 2 times, most recently from 8d4fea5 to df7f6ad Compare May 27, 2025 09:48
@ciarams87 ciarams87 force-pushed the docs/nap-waf-proposal branch from df7f6ad to 762f57f Compare May 28, 2025 08:55
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Ciara 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement-proposal Enhancement Proposal issue
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

NAP WAF Design
3 participants