Skip to content

Add support for deployment labels to helm chart #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

Butterneck
Copy link
Contributor

Proposed changes

Problem: It's not possible to specify custom labels to be applied to the nginx gateway deployment

Solution: Add support for specifying custom labels to be applied on nginx gateway deployment

Testing: Run helm diff upgrade to test changes in rendered chart

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

Copy link

nginx-bot bot commented Mar 4, 2025

Hi @Butterneck! Welcome to the project! 🎉

Thanks for opening this pull request!
Be sure to check out our Contributing Guidelines while you wait for someone on the team to review this.

Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged.
See Linking a pull request to an issue and our Pull Request Guidelines for more information.

@nginx-bot nginx-bot bot added the community label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Mar 4, 2025
@Butterneck
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@Butterneck Butterneck force-pushed the helm-support-deployment-labels branch 3 times, most recently from 01b6ba4 to 9909cef Compare March 5, 2025 13:16
@sindhushiv sindhushiv moved this from 🆕 New to External Pull Requests in NGINX Gateway Fabric Mar 5, 2025
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after change from @salonichf5 is addressed! 🚀

@Butterneck Butterneck force-pushed the helm-support-deployment-labels branch from 888fe0f to 65cd201 Compare March 5, 2025 23:55
@sjberman sjberman requested a review from salonichf5 March 11, 2025 15:51
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sjberman sjberman enabled auto-merge (squash) March 12, 2025 14:46
@sjberman sjberman merged commit b2a736f into nginx:main Mar 12, 2025
45 checks passed
@github-project-automation github-project-automation bot moved this from External Pull Requests to ✅ Done in NGINX Gateway Fabric Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants