-
Notifications
You must be signed in to change notification settings - Fork 122
Add support for deployment labels to helm chart #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deployment labels to helm chart #3194
Conversation
Hi @Butterneck! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms |
01b6ba4
to
9909cef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after change from @salonichf5 is addressed! 🚀
888fe0f
to
65cd201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Proposed changes
Problem: It's not possible to specify custom labels to be applied to the nginx gateway deployment
Solution: Add support for specifying custom labels to be applied on nginx gateway deployment
Testing: Run
helm diff upgrade
to test changes in rendered chartChecklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.