Skip to content

Added missing SnippetsFilter in the HTTPRoutes in example #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

leonseng
Copy link
Contributor

Proposed changes

HTTPRoutes in example is missing references to SnippetFilters. Updated with references as documented in https://docs.nginx.com/nginx-gateway-fabric/how-to/traffic-management/snippets/

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@leonseng leonseng requested a review from a team as a code owner February 28, 2025 00:21
@sjberman sjberman enabled auto-merge (squash) March 3, 2025 15:11
@sjberman sjberman merged commit da5b0c8 into nginx:main Mar 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants