Skip to content

Collect SnippetsFilter information #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Collect SnippetsFilter information #2677

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4ba6882
Add collection of SnippetsFilter count
bjee19 Oct 7, 2024
ad56f52
Add collection of SnippetsFilter Snippet directive, context, and tota…
bjee19 Oct 10, 2024
0748ba4
Update generated files
bjee19 Oct 10, 2024
1d4792b
Add review feedback for collector test
bjee19 Oct 11, 2024
5be5470
Adjust test case for telemetry functional test
bjee19 Oct 11, 2024
84fa60d
Refactor map range cluases
bjee19 Oct 11, 2024
98e1701
Change all instances of contextDirective to directiveContext naming
bjee19 Oct 11, 2024
1520005
Fix instance of naming
bjee19 Oct 11, 2024
a87a6f5
Add small refactoring
bjee19 Oct 11, 2024
2c39f83
Change naming of directiveContext and count variables
bjee19 Oct 14, 2024
ab3bcb7
Add edge case tests
bjee19 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor map range cluases
  • Loading branch information
@bjee19
bjee19 committed Oct 16, 2024
commit 84fa60dc3838a5a1d51eb09089be79e82ce1fcda
10 changes: 3 additions & 7 deletions internal/mode/static/telemetry/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,16 +416,14 @@ func collectSnippetsFilterSnippetsInfo(graphGetter GraphGetter) ([]string, []int

contextDirectiveMap := make(map[sfContextDirective]int)

for name := range g.SnippetsFilters {
sf := g.SnippetsFilters[name]
for _, sf := range g.SnippetsFilters {
if sf == nil {
continue
}

for nginxContext := range sf.Snippets {
snippetValue := sf.Snippets[nginxContext]

for nginxContext, snippetValue := range sf.Snippets {
var parsedContext string

switch nginxContext {
case ngfAPI.NginxContextMain:
parsedContext = "main"
Expand All @@ -440,13 +438,11 @@ func collectSnippetsFilterSnippetsInfo(graphGetter GraphGetter) ([]string, []int
}

directives := parseSnippetValueIntoDirectives(snippetValue)

for _, directive := range directives {
contextDirective := sfContextDirective{
context: parsedContext,
directive: directive,
}

contextDirectiveMap[contextDirective]++
}
}
Expand Down